test: fix fork test post upgrade#484
Merged
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
📊 Forge Coverage ReportGenerated by workflow run #777 |
pankajjagtapp
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test-only changes with no production contract modifications; risk is limited to CI correctness and fork assumptions.
Overview
Keeps mainnet fork tests valid after the 26Q2 security upgrade (block 25533308) by pinning forks to
PRE_UPGRADE_BLOCK(25_526_000) inV0MigrationFork,RevertEscrowDrain, andUpgradeStorageIntegrity, so upgrade/migration and V0 migration paths can still run from pre-upgrade chain state.In
initializeRealisticForkWithBlock, revokesHOUSEKEEPING_OPERATIONS_ROLEandGUARDIAN_ROLEfrom forkadminwhen the upgrade granted them to the operating multisig, preserving tests that expectadmincannot call sweep-style paths._setupGlobalMintBurnBucketsnow resets capacity/refill/remaining when eETH MINT/BURN limiters already exist on fork.Integration/behaviour fixes:
prelude.t.solpranks the operating multisig (not RoleRegistry owner) fordisableWhitelist;Deposit.t.solgrantsEXECUTOR_OPERATIONS_ROLEbeforedepositIntoStrategy;Withdraw.t.solgrantsHOUSEKEEPING_OPERATIONS_ROLEbeforewithdrawEther.Reviewed by Cursor Bugbot for commit 1d3eba9. Bugbot is set up for automated code reviews on this repo. Configure here.