ci: fix storage-layout check paths after src/ reorg#483
Merged
Conversation
The storage-layout workflow still referenced the old flat src/ paths (e.g. src/EETH.sol) from before contracts were moved into subdirectories (src/core, src/staking, src/oracle, ...), so every check failed with 'Could not find source file'. Update all 30 contract references to the new locations; contract names are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
|
Note: the storage-layout check is expectedly red on this PR — baselines are keyed by contract path, and the new paths have no baseline until this runs on master once. The merge push uploads all 30 baselines (push runs skip comparison), so it goes green on merge and for all PRs after. |
📊 Forge Coverage ReportGenerated by workflow run #776 |
pankajjagtapp
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Check storage layoutworkflow has been failing on every run since thesrc/directory reorg: it still referenced the old flat paths (e.g.src/EETH.sol), so each step died with:This updates all 30 contract references in
.github/workflows/foundry-storage-check.ymlto their new locations (src/core/,src/staking/,src/oracle/,src/archive/, etc.). Contract names are unchanged — only file paths moved.Verification
path:ContractNameentry checked against the source tree (file exists and declares that contract)forge inspect <entry> storage-layoutrun locally for all 30 entries — all resolve and produce a layoutExpected: the storage check is red on this PR itself
The foundry-storage-check action keys its baseline artifacts by contract path, so a PR run looks for
master.src_core_EETH.sol-EETH.json— which can't exist until the new paths run on master once. This is the action's documented first-run behavior ("An error will appear at first run!" in its README) and there is no clean way around the bootstrap.It self-heals on merge: on
pushevents the action only generates and uploads baselines (it skips the comparison entirely —if (context.eventName !== "pull_request") return), so the merge push to master will go green and seed all 30 baseline artifacts. Every subsequent PR then compares normally. Note the check is already failing on master and is not a required check (#385 merged with it red).🤖 Generated with Claude Code