Skip to content

core, internal/ethapi: validate simulate transaction gas limit - #35523

Open
szupzj18 wants to merge 1 commit into
ethereum:masterfrom
szupzj18:chris/fix/simulate-gas-limit-validation
Open

core, internal/ethapi: validate simulate transaction gas limit#35523
szupzj18 wants to merge 1 commit into
ethereum:masterfrom
szupzj18:chris/fix/simulate-gas-limit-validation

Conversation

@szupzj18

Copy link
Copy Markdown

Closes #35479.

Root cause: TransactionArgs.ToMessage skips transaction checks for simulated calls, so validation mode also bypasses the EIP-7825 gas cap.

Change: separate the contract-sender exception from transaction checks. Validation mode now enforces the transaction gas cap while still permitting contract senders.

Validation:

  • RED: focused test accepted MaxTxGas + 1 before the fix
  • go test ./internal/ethapi -count=1
  • go run ./build/ci.go test -short
  • go run ./build/ci.go test
  • go run ./build/ci.go lint
  • go run ./build/ci.go check_generate
  • go run ./build/ci.go check_baddeps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eth_simulateV1 with validation: true skips the EIP-7825 transaction gas-limit check

1 participant