eth: add example for eth_simulateV1 - #863
Open
O1ahmad wants to merge 1 commit into
Open
Conversation
Add a minimal request/response example mirroring the validated ethSimulate-simple fixture so the method documentation shows a concrete call.
4 tasks
MysticRyuujin
requested changes
Aug 10, 2026
MysticRyuujin
left a comment
MysticRyuujin
left a comment
Contributor
There was a problem hiding this comment.
The result object does not conform to the openrpc.json spec for the response object.
I know that you're going for a "minimal" example of the result, but the actual result should be the full result object as returned by the API.
I would recommend that you just copy the full output of the ethSimulate-simple.io fixture into the result. Then we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #696
Problem
eth_simulateV1had no usage example in the OpenRPC spec, making the method more challenging to use as a reference.Changes
Adds a minimal request/response example to
eth_simulateV1insrc/eth/execute.yaml, mirroring the validatedethSimulate-simplefixture (a two-call transfer with a state override).Verification
make build/make test(speccheck) passmake lint: no new warnings