eth_createAccessList: clarify gas-fee affordability when fee fields omitted - #854
Draft
MysticRyuujin wants to merge 1 commit into
Draft
Conversation
…mitted Add a normative clarification that when all gas fee fields are omitted, a client may pick implementation-defined fee values for the simulation but the request must not fail solely because the sender cannot afford those defaults. Add a testgen case and conformance fixture for an unfunded, zero-value sender.
17 tasks
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #853.
Summary
Clarifies that when all gas fee fields (
gasPrice,maxFeePerGas,maxPriorityFeePerGas) are omitted, a client may pick implementation-defined fee values for the simulation, but the request MUST NOT fail solely because the sender cannot afford those client-selected defaults. Non-zerovaluestill requires balance.Changes
src/eth/execute.yaml: normativedescriptiononeth_createAccessList.tools/testgen: newcreate-al-unfunded-sendercase — unfundedfrom, codelessto, zero value, no gas/fee fields.tests/eth_createAccessList/create-al-unfunded-sender.io: fixture expecting{"accessList":[],"gasUsed":"0x5208"}, generated from a patched go-ethereum.speccheckpasses; sibling fixtures are unchanged.Cross-client status
Verified with a single shared fixture in hive
rpc-compat. reth, nethermind, besu, erigon, and ethrex already return the expected result; go-ethereum is the sole divergence and is fixed by ethereum/go-ethereum#35397. With that fix built from source, all six clients pass.Discussion
The same affordability question applies to
eth_callandeth_estimateGas. Reviewers may prefer wording this as shared simulation-method behavior rather thancreateAccessList-only.