Update EIP-1153: Add SIR.trading incident to EIP-1153 Security Considerations - #12064
Open
notonelikeme-cmd wants to merge 1 commit into
Open
Update EIP-1153: Add SIR.trading incident to EIP-1153 Security Considerations#12064notonelikeme-cmd wants to merge 1 commit into
notonelikeme-cmd wants to merge 1 commit into
Conversation
github-actions
Bot
added
c-update
Collaborator
File
|
eth-bot
changed the title
|
The commit 9fc0b3f (as a parent of 32d60c2) contains errors. |
|
Bonjour, peut expliquer plus en détail stp merci
Le sam. 1 août 2026, 03:35, eth-bot ***@***.***> a écrit :
… *eth-bot* left a comment (ethereum/EIPs#12064)
<#12064 (comment)>
EIP Review Bot is running...
—
Reply to this email directly, view it on GitHub
<#12064?email_source=notifications&email_token=BNBOQXCEG5YL4KERWMHJKVL5HVCPLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUHA4DONRUHAY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-5148876481>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNBOQXCPAZDPQH53TRIZ2KT5HVCPLAVCNFSNUABEKJSXA33TNF2G64TZHM2DIOJXGE3TKMR3JFZXG5LFHM2TAMZUGYYDMOBXHGQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BNBOQXBKEQ5VD4LGXAJMSTL5HVCPLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUHA4DONRUHAY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/BNBOQXE5FUCZC5KRSI2R6OT5HVCPLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJUHA4DONRUHAY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a concrete, real-world example to the existing reentrancy-risk paragraph in the Security Considerations section: the March 2025 SIR.trading exploit (~$355K), which resulted from a transient storage slot used for pool-address verification being overwritten for an unrelated purpose without being cleared, then read again as a stale authorization check on a later invocation. No other changes.