Update EIP-8141: derive the JSON-RPC receipt status from the frame receipts - #12061
Open
AnkushinDaniil wants to merge 1 commit into
Open
Update EIP-8141: derive the JSON-RPC receipt status from the frame receipts#12061AnkushinDaniil wants to merge 1 commit into
AnkushinDaniil wants to merge 1 commit into
Conversation
github-actions
Bot
added
c-update
Collaborator
File
|
|
The commit 8b3d0b8 (as a parent of ec860c6) contains errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ReceiptPayloadhas no transaction-level status field, but JSON-RPC receipts have astatusfield that clients must fill in. The EIP does not say what goes there, and two implementations picked different answers.On a Nethermind/ethrex devnet the same frame transaction (a SENDER frame that reverts) was reported as
0x1by one client and0x0by the other. Both clients agreed on every consensus field: block hash, state root, receipts root, block access list hash, and the per-frame receipts byte for byte. Only the derivedstatusdiffered.This adds one paragraph pinning it: success only when every frame receipt is a success. Deriving it from the frame receipts rather than from execution state also keeps a node that executed the block and a node that only received the receipt in agreement, which a value taken from local execution cannot do.
No consensus change: the receipt payload, receipts root and gas accounting are untouched.