alloy-op-evm: drop tx gas limit cap workaround - #22136
Open
claude[bot] wants to merge 1 commit into
Open
Conversation
The vendored reth pin (f2eecc65) contains paradigmxyz/reth#25612, which makes the estimate path use the effective tx gas cap, and revm's effective cap already defaults to the EIP-7825 limit from Osaka onward. Stop overriding the raw config field and tighten the conformance test to assert the raw field stays unset while the effective cap still switches to the EIP-7825 limit for Osaka-based forks. Co-Authored-By: Claude Co-authored-by: Sebastian Stammler <seb@oplabs.co>
claude
Bot
force-pushed
the
claude/alloy-op-evm-todo-21583
branch
from
July 31, 2026 09:12
ebc06f4 to
a2cf486
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sebastian Stammler · Slack thread
Summary
Follow-up to #22130. Resolves the
TODO(21583)left in the shared OP EVM env builder.Before: OP EVM env construction force-set
cfg_env.tx_gas_limit_capto the EIP-7825 limit for Osaka-based forks, as a workaround while waiting to vendor a reth release containing paradigmxyz/reth#25612 (eth_estimateGas failing on OP chains post-EIP-7825).After: the workaround is removed. The pinned reth revision (f2eecc65) contains reth#25612, so the estimate path reads the effective cap via
CfgEnv::tx_gas_limit_cap(), and revm-context 41's effective accessor already yields the EIP-7825 limit for Osaka+ specs (andu64::MAXbefore), which is exactly what the override produced. revm's own validation and handler paths also consume the effective accessor, so behavior is unchanged everywhere.The conformance test is tightened: it now asserts the raw
tx_gas_limit_capfield staysNonefor every fork in the chronology (no override reintroduced) while the effective cap still switches to the EIP-7825 limit exactly at Osaka-based forks. The op-retheth_estimateGasEIP-7825/Karst regression test is kept, per the TODO's instruction.Fixes #21583
Generated by Claude Code