op-revm: rename OpSpecId::INTEROP to OpSpecId::LAGOON - #22134
Open
claude[bot] wants to merge 2 commits into
Open
op-revm: rename OpSpecId::INTEROP to OpSpecId::LAGOON#22134claude[bot] wants to merge 2 commits into
claude[bot] wants to merge 2 commits into
Conversation
The fork that activates interop was renamed to Lagoon across the repo (#21105), but op-revm's spec enum still called it INTEROP. Rename the variant, its "Interop" name-string constant, and all use sites to LAGOON/"Lagoon". The interop feature itself keeps its name; only the fork/spec naming changes. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co>
sebastianst
approved these changes
Jul 30, 2026
sebastianst
left a comment
Member
There was a problem hiding this comment.
It lgtm but will confirm with Interop team.
sebastianst
marked this pull request as ready for review
July 30, 2026 20:08
sebastianst
enabled auto-merge
July 30, 2026 20:12
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 30, 2026
…oon-spec-rename Resolves the merge conflict from #22130, which deleted RollupConfig::spec_id (and kona-genesis's revm feature): took develop's deletion, dropping this branch's rename edits to that file. alloy-op-evm's env.rs merged cleanly with the INTEROP->LAGOON rename applied on top of develop's changes. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sebastian Stammler · Slack thread
Before
The Interop hardfork was renamed to Lagoon across the monorepo in #21105 (the interop feature keeps its name; only the fork was renamed). The in-tree op-revm spec enum was missed: the fork/spec that Lagoon activates was still named
OpSpecId::INTEROP(with name string"Interop"), and comments at the use sites — e.g. the last entry ofFORK_CHRONOLOGYinrust/alloy-op-evm/src/env.rs— had to explain the stale name ("op-revm still names this specINTEROP").After
The spec is named
OpSpecId::LAGOON(name string"Lagoon"), matching the fork naming everywhere else in the repo. The interop feature itself keeps its "interop" name — feature-level identifiers likeis_interop_active, interop crates/packages, andsetFeature(INTEROP)are untouched.How
Mechanical rename of the
OpSpecId::INTEROPvariant, itsname::INTEROP = "Interop"constant (used byFromStr/Into<&str>), and all use sites (FORK_CHRONOLOGY, precompile spec matches in op-revm and kona's FPVM provider, kona'sRollupConfig::spec_id, and test utilities), plus the doc comments that existed only to explain the stale name.cargo +nightly fmt --checkis clean on the touched crates;cargo checkcould not run in the sandbox (the pinnedparadigmxyz/rethgit dependency is unreachable there), so compile verification relies on CI.Notes for reviewers:
OpSpecIdderives serde, so the serialized variant name changesINTEROP→LAGOON, andOpSpecId::from_strnow accepts"Lagoon"instead of"Interop". Nothing in-tree persists or parses these strings, so no alias was kept — matching Lagoon hardfork rename #21105, which added serde aliases only for persisted config keys (interop_time/interopTime).kona: reuse shared OP EVM env builder, open at time of writing) also touchesrust/alloy-op-evm; whichever lands second needs a trivial rebase.interop_time→lagoon_timerename across superchain-registry, op-geth, and dependent carveouts #21135, SDM: Update feature toggles when interop hardfork is renamed to lagoon #21129, Centralize the OP fork → implied L1 (Ethereum) fork mapping in the Rust stack #21338.Generated by Claude Code