Skip to content

op-revm: rename OpSpecId::INTEROP to OpSpecId::LAGOON - #22134

Open
claude[bot] wants to merge 2 commits into
developfrom
claude/op-revm-lagoon-spec-rename
Open

op-revm: rename OpSpecId::INTEROP to OpSpecId::LAGOON#22134
claude[bot] wants to merge 2 commits into
developfrom
claude/op-revm-lagoon-spec-rename

Conversation

@claude

@claude claude Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Requested by Sebastian Stammler · Slack thread

Before

The Interop hardfork was renamed to Lagoon across the monorepo in #21105 (the interop feature keeps its name; only the fork was renamed). The in-tree op-revm spec enum was missed: the fork/spec that Lagoon activates was still named OpSpecId::INTEROP (with name string "Interop"), and comments at the use sites — e.g. the last entry of FORK_CHRONOLOGY in rust/alloy-op-evm/src/env.rs — had to explain the stale name ("op-revm still names this spec INTEROP").

After

The spec is named OpSpecId::LAGOON (name string "Lagoon"), matching the fork naming everywhere else in the repo. The interop feature itself keeps its "interop" name — feature-level identifiers like is_interop_active, interop crates/packages, and setFeature(INTEROP) are untouched.

How

Mechanical rename of the OpSpecId::INTEROP variant, its name::INTEROP = "Interop" constant (used by FromStr/Into<&str>), and all use sites (FORK_CHRONOLOGY, precompile spec matches in op-revm and kona's FPVM provider, kona's RollupConfig::spec_id, and test utilities), plus the doc comments that existed only to explain the stale name. cargo +nightly fmt --check is clean on the touched crates; cargo check could not run in the sandbox (the pinned paradigmxyz/reth git dependency is unreachable there), so compile verification relies on CI.

Notes for reviewers:


Generated by Claude Code

The fork that activates interop was renamed to Lagoon across the repo
(#21105), but op-revm's spec enum still called it INTEROP. Rename the
variant, its "Interop" name-string constant, and all use sites to
LAGOON/"Lagoon". The interop feature itself keeps its name; only the
fork/spec naming changes.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>

@sebastianst sebastianst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lgtm but will confirm with Interop team.

@sebastianst
sebastianst marked this pull request as ready for review July 30, 2026 20:08
@sebastianst
sebastianst requested review from a team as code owners July 30, 2026 20:08

@ajsutton ajsutton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sebastianst
sebastianst enabled auto-merge July 30, 2026 20:12
@sebastianst
sebastianst added this pull request to the merge queue Jul 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 30, 2026
…oon-spec-rename

Resolves the merge conflict from #22130, which deleted RollupConfig::spec_id
(and kona-genesis's revm feature): took develop's deletion, dropping this
branch's rename edits to that file. alloy-op-evm's env.rs merged cleanly with
the INTEROP->LAGOON rename applied on top of develop's changes.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants