op-reth: assert builder_config shares its live interop failsafe handle - #22117
Open
op-will wants to merge 1 commit into
Open
op-reth: assert builder_config shares its live interop failsafe handle#22117op-will wants to merge 1 commit into
op-will wants to merge 1 commit into
Conversation
`builder_config_reflects_node_fields` sets each node field before calling the accessor, so it proves values propagate but not that the Arc-backed handles stay shared. Only the DA config had a liveness test. That gap matters most for the interop failsafe: the filter client writes it after the payload builder is already constructed, so a config that copied the flag's value instead of sharing the handle would leave the builder permanently ungated while every existing assertion still passed. Interop txs would then be included during a failsafe. Add liveness tests for the interop failsafe and the SDM opt-in, mirroring the DA case: take the config first, flip the node's handle after, assert the config observes it. The failsafe test also clears the flag to prove a single shared handle rather than a one-way latch. Confirmed to fail by replacing the accessor's `interop_failsafe` with `InteropFailsafe::default()`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
op-will
force-pushed
the
test/builder-config-interop-failsafe-live-handle
branch
from
July 29, 2026 22:36
3365fcf to
e4f2491
Compare
op-will
marked this pull request as ready for review
July 30, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds liveness tests for two
OpBuilderConfighandles thatOpNode::builder_config()threads through: the interop failsafe and the SDM operator opt-in.Why
builder_config_reflects_node_fieldssets each node field before calling the accessor, so it proves values propagate — but not that theArc-backed handles stay shared. Of the three shared handles, onlyda_confighad a liveness test (builder_config_da_is_live_shared_handle).That gap matters most for the interop failsafe, because of when it is written. The filter client sets it at runtime, long after the payload builder has been constructed. So a refactor that copied the flag's value instead of sharing the handle — say
interop_failsafe: InteropFailsafe::default(), or a plainbool— would leave the builder permanently ungated, and every existing assertion would still pass. Interop transactions would be included during a failsafe.The same reasoning applies to
operator_sdm_opt_in, which the admin RPC flips after startup.How
Mirrors the existing DA case exactly: take the config first, flip the node's handle after, assert the config observes the change. The failsafe test additionally clears the flag, proving a single shared handle rather than a one-way latch.
Verification
builder_configtests pass.interop_failsafewithInteropFailsafe::default()makes the new test fail with its intended message (builder_config must carry the node's live interop failsafe handle, not a detached copy), confirming it detects the regression rather than passing vacuously.cargo +nightly fmtclean.Tests only — no production code touched.
🤖 Generated with Claude Code