op-acceptance-tests: cover kona-sp1 proposal safety - #22105
Open
Inphi wants to merge 9 commits into
Open
Conversation
Exercise foreign-parent adoption, latent super-root handling, and shallow L1 reorg recovery without entering the proving path. Make proposal cadence and L1 confirmation depth configurable so the acceptance tests can establish deterministic safety margins.
Make WithZK apply the standard game and proposer defaults, and resolve the SP1 vkey once from KONA_SP1_ELF_DIR.
Remember rejected game indices so later otherwise-valid descendants cannot become canonical parents. Clear index-keyed verdicts when the factory cursor resets and cover the behavior with acceptance and state-level regressions.
Wait for the exact super-root timestamp and assert only the observable parent-safety invariant, avoiding timing proxies that can introduce flakes.
Inphi
force-pushed
the
inphi/acc-tests-zk
branch
from
July 29, 2026 16:34
306dfe4 to
03f6fb8
Compare
Inphi
marked this pull request as ready for review
July 29, 2026 16:57
Run ZK proposer and challenger tests in parallel with longer challenge and prove windows. Let safety tests seed adversarial games before starting the proposer, avoiding proposal-interval races. Pause interop explicitly when testing a latent super-root RPC.
digorithm
approved these changes
Jul 30, 2026
digorithm
left a comment
digorithm
left a comment
Contributor
There was a problem hiding this comment.
Just a few non-blocking comments!
Inphi
enabled auto-merge
July 30, 2026 22:28
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends ZK dispute game acceptance coverage for the kona-sp1 proposer’s game-creation path.
New scenarios verify that the proposer:
Bugfix
This change also fixes a bug in the kona-sp1-proposer where it extends an invalid game (with a valid output root but invalid parent) because it forgot the invalid parent game. The proposer now remembers invalid subtrees until factory history resets.
Devstack changes
ZK tests now use an explicit
WithZK()preset with targeted overrides for proposal cadence. The preset also resolves one SP1 vkey for both game deployment and proposer artifacts, avoiding mismatched configuration.Also adjusted the default zk challenge and prove durations to reduce flakiness
Related: #18326