Skip to content

op-deployer: remove stale issue 20912 TODOs - #22044

Merged
mds1 merged 1 commit into
developfrom
fix/pcd-stale-20912-todos
Jul 27, 2026
Merged

op-deployer: remove stale issue 20912 TODOs#22044
mds1 merged 1 commit into
developfrom
fix/pcd-stale-20912-todos

Conversation

@lumoswiz

Copy link
Copy Markdown
Contributor

Description

Removes stale TODO references that reopened #20912. Bumps OPContractsManagerV2 from 7.2.2 to 7.2.3 and regenerates the semver lock. No behavior, ABI, or storage changes.

Additional context

The remaining genesis output-root work is tracked by #21963.

Metadata

Closes #20912

@lumoswiz
lumoswiz marked this pull request as ready for review July 27, 2026 13:52
@lumoswiz
lumoswiz requested review from a team and digorithm July 27, 2026 13:52
@lumoswiz
lumoswiz requested a review from a team as a code owner July 27, 2026 13:52

@OptimismBot OptimismBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — safe to merge.

Reviewed all 3 changed files:

  • OPContractsManagerV2.sol: removes two stale TODO(#20912) comments and bumps semver 7.2.2 → 7.2.3 (patch). The anchor-root safety guard the TODO referenced is present and enforced — an initial deployment with PLACEHOLDER_STARTING_ANCHOR_ROOT still reverts with OPContractsManagerV2_InvalidGameConfigs(). No logic, ABI, or storage changes.
  • op-chain-ops/interopgen/deploy.go: comment-only removal of the corresponding stale TODO. No behavior change.
  • snapshots/semver-lock.json: regenerated hashes for only the OPCM V2 entry, consistent with the source edit.

No malicious code and no blocking bugs found.

@mds1
mds1 added this pull request to the merge queue Jul 27, 2026
Merged via the queue into develop with commit 0fc6e89 Jul 27, 2026
313 of 322 checks passed
@mds1
mds1 deleted the fix/pcd-stale-20912-todos branch July 27, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PCD] Build the continuation deploy input from prepared state

5 participants