WIP scheduled tx - #17435
Closed
maurelian wants to merge 2 commits into
Closed
Conversation
This was referenced Sep 11, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maurelian
force-pushed
the
jm/timelock-schedule-tx
branch
from
September 11, 2025 19:45
6da20e8 to
0c607c1
Compare
alcueca
reviewed
Sep 12, 2025
| // A transaction can only be scheduled once, regardless of whether it has been cancelled or not. | ||
| if (scheduledTransactions[_safe][txHash].executionTime != 0) { | ||
| revert TimelockGuard_TransactionAlreadyScheduled(); | ||
| } |
Contributor
There was a problem hiding this comment.
I think this is sufficient to ensure that the same signatures can't ever be used twice, because the data used to derive txHash is the same used to derive the signatures. You can't change txHash without having to change the signatures as well.
opgitgovernance
added
the
S-stale
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
scheduleTransaction()function.