Move artwork images into dist/images and update gallery paths - #8
Open
ethan-CCY wants to merge 2 commits into
Open
Move artwork images into dist/images and update gallery paths#8ethan-CCY wants to merge 2 commits into
ethan-CCY wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Artwork/intodist/images/Artwork/so they are in the served images folder.index.htmlto replace the three gallery placeholder sources withdist/images/Artwork/03_Harbor Light.png,dist/images/Artwork/02_Botanical Whisper.jpeg, anddist/images/Artwork/01_Quiet Corner.jpeg.dist/images/Artwork/and relocated the provided image files into it.Testing
python -m http.server 8000and confirmed the page loads and assets are reachable by capturing a screenshot with Playwright saved toartifacts/landing-page-artwork.png, which completed successfully.index.htmlreferences appear as intended by inspecting the rendered page HTML after the server run, with no errors reported during the automated screenshot run.Codex Task