Skip to content

Swap hero/about images, add artwork thumbnails and constrain image sizing - #11

Open
ethan-CCY wants to merge 1 commit into
mainfrom
codex/add-artwork-thumbnails-and-image-replacements-hkpozt
Open

Swap hero/about images, add artwork thumbnails and constrain image sizing#11
ethan-CCY wants to merge 1 commit into
mainfrom
codex/add-artwork-thumbnails-and-image-replacements-hkpozt

Conversation

@ethan-CCY

Copy link
Copy Markdown
Owner

Motivation

  • Replace placeholder artwork with project-provided images and show small thumbnails inside feature cards without changing the original layout and visual framing.
  • Ensure images do not break layout across desktop and mobile by adding fit/size rules and keeping existing SVG behavior intact.

Description

  • HTML: replaced hero right-side images with Artwork/05_Harbor Light2.jpeg, replaced About large box with Artwork/04_A_festive.jpeg, and replaced each .feature icon images with artwork thumbs (Artwork/03_Harbor Light.png, Artwork/02_Botanical Whisper.jpeg, Artwork/01_Quiet Corner.jpeg) in index.html.
  • SCSS/CSS: added thumbnail sizing and cropping rules and preserved SVG handling by updating src/scss/layout/_features.scss and src/scss/layout/_hero.scss, and added corresponding built CSS entries to dist/css/style.css to constrain .feature-icon to 72×72 and apply object-fit: cover to hero/about images while keeping SVG max-width:none.
  • Minor fix: limited a broad rule that previously applied max-width:none to both imgs and svgs so images remain constrained (SVG-only exception preserved).
  • Files changed: index.html, src/scss/layout/_hero.scss, src/scss/layout/_features.scss, dist/css/style.css.

Testing

  • Launched a local web server (python -m http.server 8000) and rendered the updated page with Playwright to capture a full-page screenshot (artifacts/landing-page-updated.png), which completed successfully for visual verification.
  • Performed quick source checks (grep/inspection) to confirm new src paths and CSS rules are present and committed; no automated unit tests exist for this static change.
  • Result: visual smoke test (screenshot) passed and changes committed.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba987c634c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dist/css/style.css
Comment on lines +42 to +43
:root .asset-light{display:block;}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove asset display reset that overrides lights-off theme

These new :root rules force .asset-light visible and .asset-dark hidden, and they appear after the existing .lights-off .asset-* rules with equal specificity, so they win in the cascade. Since checkLights in src/js/main.js toggles body.lights-off (not body.dark/has-dark-mode), dark mode no longer swaps to dark assets and the light versions remain displayed even when the switch is off.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant