Swap hero/about images, add artwork thumbnails and constrain image sizing - #11
Swap hero/about images, add artwork thumbnails and constrain image sizing#11ethan-CCY wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba987c634c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| :root .asset-light{display:block;} |
There was a problem hiding this comment.
Remove asset display reset that overrides lights-off theme
These new :root rules force .asset-light visible and .asset-dark hidden, and they appear after the existing .lights-off .asset-* rules with equal specificity, so they win in the cascade. Since checkLights in src/js/main.js toggles body.lights-off (not body.dark/has-dark-mode), dark mode no longer swaps to dark assets and the light versions remain displayed even when the switch is off.
Useful? React with 👍 / 👎.
Motivation
Description
Artwork/05_Harbor Light2.jpeg, replaced About large box withArtwork/04_A_festive.jpeg, and replaced each.featureicon images with artwork thumbs (Artwork/03_Harbor Light.png,Artwork/02_Botanical Whisper.jpeg,Artwork/01_Quiet Corner.jpeg) inindex.html.src/scss/layout/_features.scssandsrc/scss/layout/_hero.scss, and added corresponding built CSS entries todist/css/style.cssto constrain.feature-iconto 72×72 and applyobject-fit: coverto hero/about images while keeping SVGmax-width:none.max-width:noneto both imgs and svgs so images remain constrained (SVG-only exception preserved).index.html,src/scss/layout/_hero.scss,src/scss/layout/_features.scss,dist/css/style.css.Testing
python -m http.server 8000) and rendered the updated page with Playwright to capture a full-page screenshot (artifacts/landing-page-updated.png), which completed successfully for visual verification.srcpaths and CSS rules are present and committed; no automated unit tests exist for this static change.Codex Task