Bump go 1.27.1 by pjsharath28 · Pull Request #22373 · etcd-io/etcd

pjsharath28 · 2026-09-02T07:16:59Z

Signed-off-by: Sharath P J <pjsharath28@gmail.com>

codecov · 2026-09-02T07:46:26Z

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.97%. Comparing base (b655785) to head (f043a5b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
server/etcdserver/api/v2store/store.go	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
cache/cache.go	`91.30% <100.00%> (+3.60%)`	⬆️
server/embed/etcd.go	`80.99% <100.00%> (+5.25%)`	⬆️
server/etcdserver/metrics.go	`72.54% <100.00%> (+5.27%)`	⬆️
server/etcdserver/api/v2store/store.go	`88.39% <0.00%> (+5.27%)`	⬆️

... and 441 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22373      +/-   ##
==========================================
+ Coverage   69.73%   72.97%   +3.23%     
==========================================
  Files         448      448              
  Lines       38058    31556    -6502     
==========================================
- Hits        26541    23028    -3513     
+ Misses      10101     8525    -1576     
+ Partials     1416        3    -1413

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b655785...f043a5b. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pjsharath28 · 2026-09-02T07:51:16Z

Commit 1 — Go version bump
Updates .go-version, all go.mod files, and go.work to Go 1.27.1.

Commit 2 — fix: use value dereference for v2error.Error with %w
Caught by govet during the upgrade. n.Write() returns a pointer but
Error() is on the value receiver, so passing the pointer to %w
defeats errors.Is/errors.As. Dereferencing fixes it.

…0.8.1 Signed-off-by: Sharath P J <pjsharath28@gmail.com>

pjsharath28 · 2026-09-02T08:01:29Z

Commit 3 - fix: address staticcheck SA4023 warnings
Bumped honnef.co/go/tools to v0.8.1 to support Go 1.27. This
surfaced 3 new lint warnings which are fixed in this commit:

cache/cache.go — removed a redundant nil check
metrics.go, embed/etcd.go — suppressed false positives
(these functions intentionally always fail on non-linux)

Signed-off-by: Sharath P J <pjsharath28@gmail.com>

pjsharath28 · 2026-09-02T08:28:43Z

Commit 4 - test: update TestLogRotation expected error for Go 1.27 json/v2

Go 1.27 enables encoding/json/v2 by default. The v2 implementation
formats error paths for embedded structs differently — it drops the
intermediate embedded type name:

Go 1.26: logRotationConfig.Logger.maxsize
Go 1.27: logRotationConfig.maxsize

No production code changed - just updated the hardcoded expected string
in the test to match the new format.

…hesis Dockerfile Signed-off-by: Sharath P J <pjsharath28@gmail.com>

pjsharath28 · 2026-09-02T09:14:29Z

Commit 5 - fix: sync go.work and go.mod versions in antithesis Dockerfile

The Dockerfile clones from main but copies pkg from the current
branch. During a Go version bump, the cloned go.work/go.mod files
are still on the old version while the copied pkg/go.mod requires the
new one — causing go get to fail. Fixed by syncing go.work and all
go.mod files to match the copied pkg/go.mod after the copy step.

pjsharath28 · 2026-09-02T10:17:04Z

/retest

ivanvc · 2026-09-03T04:11:14Z

+# Sync go.work and all go.mod versions to match the copied pkg module,
+# since the cloned branch may be behind the copied pkg module requirements.
+RUN eval $(grep -E '^(go|toolchain) ' tests/antithesis/pkg/go.mod | awk '{print toupper($1)"="$2}') && \
+    go work edit -go=${GO} -toolchain=${TOOLCHAIN} && \
+    find . -name 'go.mod' -not -path './tests/antithesis/*' -exec \
+        go mod edit -go=${GO} -toolchain=${TOOLCHAIN} {} \;


Why is line 9 not working anymore? I remember that it failed in a previous minor version bump, and the solution was to set the environment variable.

The fix in 4e39cdf was for a patch bump mismatch (base image 1.25.0 vs toolchain 1.25.1) where go env -w was enough since the go directive didn't need to change.

In this case though, the copied pkg/go.mod requires go 1.27 while the cloned go.work still says go 1.26, so we also need go work edit + go mod edit to update the directive itself. Happy to revisit if there's a cleaner way to handle this!

Ah, got it. I wanted to replace this with the utilities we already have, something like:

RUN awk 'match($0, /^toolchain go/) {gsub(/go/, "", $2); print $2}' tests/antithesis/pkg/go.mod > .go-version && make sync-toolchain-directive

But the problem is that we would only update the toolchain, not the go directive.

ivanvc · 2026-09-03T04:11:48Z

Huh, in #22302 I was getting errors from using an old golangci-lint version. We haven't updated it (#22363), but for some reason it works on your branch 🤔

ivanvc · 2026-09-04T23:51:35Z

Can a second pair of eyes look at this? Especially the last three commits bdc41f1, 178320b, f043a5b

/lgtm
/cc @ahrtr @fuweid @serathius

fuweid

Could you please squash the commits into one? Don't think we need 5 commits to bump goversion thanks

kubernetes-prow · 2026-09-05T00:30:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pjsharath28
Once this PR has been reviewed and has the lgtm label, please ask for approval from ivanvc. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pjsharath28 · 2026-09-05T12:54:33Z

Could you please squash the commits into one? Don't think we need 5 commits to bump goversion thanks

Just thought it'd be easier to keep them separate for the reviewers. Once everything looks good, I'm happy to squash. Hope that would be fine.

fuweid · 2026-09-05T18:41:09Z

-		if err := c.getWatch(); err != nil {
-			fmt.Printf("getWatch failed, will retry after %v: %v\n", backoff, err)
-		}
+		err := c.getWatch()


suggest using comment instead of changing code

//nolint:staticcheck // SA4023: Related diagnostic for the defensive nil check in getWatchLoop.

fuweid · 2026-09-05T18:43:38Z

 COPY pkg /etcd/tests/antithesis/pkg
+# Sync go.work and all go.mod versions to match the copied pkg module,
+# since the cloned branch may be behind the copied pkg module requirements.
+RUN eval $(grep -E '^(go|toolchain) ' tests/antithesis/pkg/go.mod | awk '{print toupper($1)"="$2}') && \


maybe we can try this

# The copied module may require a newer Go version than the cloned workspace. RUN if [ -f go.work ]; then go work use; fi

fuweid · 2026-09-05T18:45:22Z

 # cloning etcd
 ARG REF=main
 RUN git clone --depth=1 https://github.com/etcd-io/etcd.git --branch=${REF} /etcd
-RUN go env -w GOTOOLCHAIN="go$(cat .go-version)"


We can try this because GO_IMAGE_TAG is aligned with .go-version in root.

# Use the selected build image's toolchain, including when building older refs. ENV GOTOOLCHAIN=local

pjsharath28 added 2 commits September 2, 2026 12:45

Bump go 1.27.1

7defdea

Signed-off-by: Sharath P J <pjsharath28@gmail.com>

fix: use value dereference for v2error.Error with %w

91c7264

Signed-off-by: Sharath P J <pjsharath28@gmail.com>

kubernetes-prow Bot added area/clientv3 area/etcdctl area/etcdutl area/performance area/testing area/tooling size/M labels Sep 2, 2026

fix: address staticcheck issues after bumping honnef.co/go/tools to v…

bdc41f1

…0.8.1 Signed-off-by: Sharath P J <pjsharath28@gmail.com>

pjsharath28 marked this pull request as draft September 2, 2026 08:22

kubernetes-prow Bot added the do-not-merge/work-in-progress label Sep 2, 2026

test: update TestLogRotation error message for Go 1.27 encoding/json/v2

178320b

Signed-off-by: Sharath P J <pjsharath28@gmail.com>

fix: sync go.work and go.mod versions from copied pkg module in antit…

f043a5b

…hesis Dockerfile Signed-off-by: Sharath P J <pjsharath28@gmail.com>

pjsharath28 marked this pull request as ready for review September 2, 2026 09:14

kubernetes-prow Bot removed the do-not-merge/work-in-progress label Sep 2, 2026

ivanvc mentioned this pull request Sep 3, 2026

[DO NOT MERGE] Bump go toolchain to 1.27rc3 #22302

Closed

ivanvc reviewed Sep 3, 2026

View reviewed changes

ivanvc mentioned this pull request Sep 3, 2026

Bump to Go 1.27.1 / 1.26.8 #22372

Open

19 tasks

kubernetes-prow Bot requested review from ahrtr, fuweid and serathius September 4, 2026 23:51

kubernetes-prow Bot assigned ivanvc Sep 4, 2026

kubernetes-prow Bot added the lgtm label Sep 4, 2026

fuweid requested changes Sep 5, 2026

View reviewed changes

fuweid reviewed Sep 5, 2026

View reviewed changes

Uh oh!

Conversation

pjsharath28 commented Sep 2, 2026

Uh oh!

codecov Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pjsharath28 commented Sep 2, 2026

Uh oh!

pjsharath28 commented Sep 2, 2026

Uh oh!

pjsharath28 commented Sep 2, 2026

Uh oh!

pjsharath28 commented Sep 2, 2026

Uh oh!

pjsharath28 commented Sep 2, 2026

Uh oh!

ivanvc Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

pjsharath28 Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

ivanvc Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

ivanvc commented Sep 3, 2026

Uh oh!

ivanvc commented Sep 4, 2026

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

kubernetes-prow Bot commented Sep 5, 2026

Uh oh!

pjsharath28 commented Sep 5, 2026

Uh oh!

fuweid Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

fuweid Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

fuweid Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Sep 2, 2026 •

edited

Loading