Skip to content

Fix typos in comments and two error messages - #22368

Merged
serathius merged 1 commit into
etcd-io:mainfrom
MsfPablo:fix-typos
Sep 3, 2026
Merged

Fix typos in comments and two error messages#22368
serathius merged 1 commit into
etcd-io:mainfrom
MsfPablo:fix-typos

Conversation

@MsfPablo

@MsfPablo MsfPablo commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Typo fixes found with codespell. No functional changes; no identifiers renamed.

Comments:

  • thi type -> this type (client/v3/internal/endpoint)
  • entires -> entries (server/embed/config.go)
  • remaning -> remaining (server/embed/etcd.go)
  • depercate -> deprecate (server/etcdserver/api/rafthttp/pipeline.go)
  • revered order -> reversed order (server/storage/schema/actions.go)
  • contious -> continuous (cache/demux.go)

Error messages:

  • failed to get the lastest snapshot -> latest (etcdutl)
  • failed reading anotation -> annotation (tools/proto-annotations)

Signed-off-by: Pablo Garcia Caceres <pablogarciacaceres5@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown

Hi @MsfPablo. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MsfPablo, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius

Copy link
Copy Markdown
Member

/ok-to-test

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.67%. Comparing base (b655785) to head (e6b7e73).

Files with missing lines Patch % Lines
etcdutl/etcdutl/migrate_command.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
cache/demux.go 85.84% <ø> (ø)
server/embed/config.go 79.56% <ø> (ø)
server/embed/etcd.go 75.73% <ø> (ø)
server/etcdserver/api/rafthttp/pipeline.go 97.40% <ø> (ø)
server/storage/schema/actions.go 93.75% <ø> (ø)
etcdutl/etcdutl/migrate_command.go 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22368      +/-   ##
==========================================
- Coverage   69.73%   69.67%   -0.07%     
==========================================
  Files         448      448              
  Lines       38058    38058              
==========================================
- Hits        26541    26518      -23     
- Misses      10101    10118      +17     
- Partials     1416     1422       +6     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b655785...e6b7e73. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pjsharath28

Copy link
Copy Markdown
Member

/retest

@serathius
serathius merged commit 8b3de3c into etcd-io:main Sep 3, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants