Skip to content

Stop purging v2 snapshot files - #22271

Merged
ahrtr merged 1 commit into
etcd-io:mainfrom
ahrtr:20260812_purge_snapfile
Aug 13, 2026
Merged

Stop purging v2 snapshot files#22271
ahrtr merged 1 commit into
etcd-io:mainfrom
ahrtr:20260812_purge_snapfile

Conversation

@ahrtr

@ahrtr ahrtr commented Aug 12, 2026

Copy link
Copy Markdown
Member

part of #20187

We don't generate v2 snapshot files anymore, so no need to purge v2 snapshot files.

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr

ahrtr commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

/test pull-etcd-contrib-mixin

@ahrtr

ahrtr commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

cc @fuweid @ivanvc @serathius

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.66%. Comparing base (faafe77) to head (ce48442).

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/server.go 84.00% <100.00%> (+0.01%) ⬆️

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22271      +/-   ##
==========================================
- Coverage   69.71%   69.66%   -0.06%     
==========================================
  Files         449      449              
  Lines       38187    38182       -5     
==========================================
- Hits        26622    26599      -23     
- Misses      10141    10151      +10     
- Partials     1424     1432       +8     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faafe77...ce48442. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
ahrtr merged commit 0836b69 into etcd-io:main Aug 13, 2026
34 checks passed
@ahrtr
ahrtr deleted the 20260812_purge_snapfile branch August 13, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants