[release-3.5] Fix unbounded io.ReadAll on peer lease HTTP handler body - #22161
Conversation
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
Current branch with the 4 GiB setting "resources": {
"limits": {
"cpu": "6",
"memory": "4Gi"
},
"requests": {
"cpu": "6",
"memory": "4Gi"
}Maximum resident set size (kbytes): 4572216 = 4.572216 GiB ➜ tests git:(release-3.5) /usr/bin/time -v go test -tags cluster_proxy -race -cpu 4 -count 1 \
-run 'TestV3Lease(Renew|TimeToLive)Stress' go.etcd.io/etcd/tests/v3/integration
ok go.etcd.io/etcd/tests/v3/integration 42.581s
Command being timed: "go test -tags cluster_proxy -race -cpu 4 -count 1 -run TestV3Lease(Renew|TimeToLive)Stress go.etcd.io/etcd/tests/v3/integration"
User time (seconds): 75.14
System time (seconds): 9.80
Percent of CPU this job got: 194%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:43.62
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 4572216
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 351
Minor (reclaiming a frame) page faults: 2388962
Voluntary context switches: 135444
Involuntary context switches: 23507
Swaps: 0
File system inputs: 52616
File system outputs: 389184
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 4096
Exit status: 0probably we should increase memory limit to mitigate it first and then see if we can backport something back |
Thanks for looking into this. Can we merge this PR and experiment this in a separate PR? cc @ivanvc |
Sure and merged |
Backport #22132 to 3.5
cc @fuweid @ivanvc @serathius