feat(es_extended): auto-detect Legacy vs Enhanced edition#1810
Closed
ASTROWwwW wants to merge 1 commit into
Closed
feat(es_extended): auto-detect Legacy vs Enhanced edition#1810ASTROWwwW wants to merge 1 commit into
ASTROWwwW wants to merge 1 commit into
Conversation
Expose ESX.IsEnhanced (server: gamename convar, client: IsGameEnhancedVersion native) and a replicated esx:enhanced convar so any resource can self-configure. Gate the OneSync Infinity requirement on Legacy only, since Enhanced runs OneSync natively.
Zykem
requested changes
Jul 23, 2026
Zykem
left a comment
Zykem
left a comment
Member
There was a problem hiding this comment.
this PR is more of an esx_lib thing tbh. the whole point of creating the lib was to keep the core clean and not filled with modules that don't belong there. same logic applies to this variable, it has nothing to do with core functionality, so it should live in the lib instead.
Contributor
Author
|
Agreed, this belongs in esx_lib rather than the core. Moving the detection into the lib and opening a single PR against dev. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
ESX.IsEnhancedso one codebase runs on both Legacy and GTA V Enhanced (server:gamenameconvar, client:IsGameEnhancedVersion, mirrored to a replicatedesx:enhancedconvar). OneSync Infinity is enforced on Legacy only.PR Checklist