refactor(esx_property): optimize property synchronization to reduce network traffic#99
Closed
ifaisal-swe wants to merge 1 commit into
Closed
refactor(esx_property): optimize property synchronization to reduce network traffic#99ifaisal-swe wants to merge 1 commit into
ifaisal-swe wants to merge 1 commit into
Conversation
When properties are updated (bought, sold, modified), the server was sending the entire Properties array to all clients, causing significant network lag with large property files or many players online. Changes: - Added new client event handler `esx_property:updateProperty` that updates only the specific property instead of syncing all properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes property synchronization by sending only the updated property to clients instead of the entire Properties array. This reduces network traffic.
Motivation
Previously, any property update sent the entire Properties array to all clients. With large property files, this caused:
Now only the single changed property is sent, dramatically reducing network traffic.
Implementation Details
Server (
server/main.lua):TriggerClientEvent("esx_property:syncProperties", -1, Properties)TriggerClientEvent('esx_property:updateProperty', -1, PropertyId, Properties[PropertyId])Client (
client/main.lua):RegisterNetEvent("esx_property:updateProperty")handlerUsage Example
-- Server: Send single property update
-- Client: Receives and updates single property
PR Checklist