refactor: integrate global Medal.tv auto-clipping & remove local implementation#115
Open
rwixy wants to merge 2 commits into
Open
refactor: integrate global Medal.tv auto-clipping & remove local implementation#115rwixy wants to merge 2 commits into
rwixy wants to merge 2 commits into
Conversation
rwixy
force-pushed
the
esx_ambulancejob-medal-fix-clean
branch
from
July 21, 2026 07:23
354af31 to
c32dfbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the local, standalone Medal.tv auto-clipping assets and scripts from
esx_ambulancejoband refactors the death clip trigger to consume the centralized globalxLib.medalmodule.Motivation
Previously,
esx_ambulancejobmaintained its own local NUI files (html/medal.html,html/medal.js), dedicated client script (client/medal.lua), and duplicate configuration blocks to handle saving clips upon player death. Centralizing the Medal.tv functionality insideesx_liballowsesx_ambulancejobto decouple itself from standalone clip logic, cleaning up the resource structure and aligning with the global library standards.Implementation Details
Cleaned Assets: Deleted local NUI files
html/medal.htmlandhtml/medal.jsand removed their declarations fromfxmanifest.lua.Script Removal: Deleted
client/medal.luaand removed its reference.Centralized configuration: Removed the
Config.Medalconfiguration block fromconfig.luato prevent configuration redundancy.Library Import: Added
@esx_lib/imports.luatoshared_scriptsinfxmanifest.luato give the resource access to the global xLib helper modules.Refactored Death Clip: Simplified
TriggerMedalDeathClip()inclient/main.luato callxLib.medal.triggerClip()without arguments, offloading all clip invocation, API details, and default settings toesx_lib.Usage Example
PR Checklist