Change version metadata key to 'legacyversion'#101
Closed
voidvalue-dev wants to merge 2 commits into
Closed
Conversation
Signed-off-by: cesarmr-github <167689141+cesarmr-github@users.noreply.github.com>
|
|
|
Thanks for the contribution :) |
Author
|
ready |
Member
|
Hey thanks for contributing. So instead of replacing version with the legacyversion it should look up for the actual hud version. |
Signed-off-by: cesarmr-github <167689141+cesarmr-github@users.noreply.github.com>
Author
ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we avoid the version checker error.
If you look at the “version” metadata in the fxmanifest, you will get an error because it is being compared with the latest version of the esx core. So we will look at the “legacyversion” metadata.