RR7 5/5: Upgrade to react-router v7#2002
Open
GregorShear wants to merge 1 commit into
Open
Conversation
Bumps react-router and react-router-dom to v7 and removes the future-flag object, since those flags are now the default behavior in v7. With the flags already enabled in v6 (prior commit), this swap is behavior-neutral. react-router-dom is kept installed (it re-exports react-router in v7) so the 32 existing 'react-router-dom' import sites and use-query-params continue to work unchanged. Typecheck passes clean; app boots and the out-of-layout, dialog-over-table, and 404 routing patterns all verified in-app on v7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the React Router v7 upgrade stack (5 of 5). Base:
greg/rr7-4-future-flags.Bumps
react-routerandreact-router-domto v7 (7.17.0) and removes thefutureflag object, since those flags are now the default in v7. With the flags already enabled in PR 4, this swap is behavior-neutral — the only code change is deleting the flags.react-router-domkept installed (it re-exportsreact-routerin v7), so the 32 existingreact-router-domimport sites anduse-query-params(peerreact-router-dom: >=5) keep working unchanged. No import rewrite needed.href(). Stays oncreateBrowserRouter./oauth), dialog-over-table, and 404 patterns all verified in-app on v7.Does not address the
routes.tspath/title duplication — that's an orthogonal track (flatpathshelper or, later, framework mode).