RR7 4/5: Enable react-router v7 future flags on v6#2001
Open
GregorShear wants to merge 1 commit into
Open
Conversation
Opts into v7 routing semantics while still on v6 so the eventual package swap is behavior-neutral. v7_relativeSplatPath is already satisfied by the splat cleanup; the loader/action/fetcher flags are no-ops here (no loaders or actions in use). v7_startTransition is set on RouterProvider rather than the router options. Verified app boots and the collections create dialog still renders over the table under the new splat semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the React Router v7 upgrade stack (4 of 5). Base:
greg/rr7-3-splat-cleanup.Opts into v7 routing semantics while still on v6, so the actual package swap (PR 5) is behavior-neutral and easy to roll back.
v7_relativeSplatPath— already satisfied by the splat cleanup in PR 3.v7_fetcherPersist,v7_normalizeFormMethod,v7_partialHydration,v7_skipActionErrorRevalidation— no-ops here: the app uses no loaders/actions/fetchers (audited: noformMethod, nofallbackElement, no react-routerdefer()/json()).v7_startTransition— set onRouterProvider(it's a render flag, not a router option).Verified the app boots and the collections create dialog still renders over the table under the new splat semantics. Note: these flags are reverted in PR 5 because they become the default in v7.