RR7 3/5: Clean up admin/billing and collections splat routes#2000
Open
GregorShear wants to merge 1 commit into
Open
RR7 3/5: Clean up admin/billing and collections splat routes#2000GregorShear wants to merge 1 commit into
GregorShear wants to merge 1 commit into
Conversation
- Collapse the admin/billing splat into a billing parent with an index route and a paymentMethod/new child, removing the duplicate billing registration and the dead /admin/billing/billing route. - As a result, /admin/billing/<garbage> now falls through to PageNotFound instead of rendering an empty content card (the splat no longer swallows it). - Wrap both billing routes in lazyElement for consistent error boundaries. - Drop the /* from the collections parent path; the existing * child handles the splat, matching react-router's v7_relativeSplatPath guidance. Behavior verified in-app: /admin/billing, /admin/billing/paymentMethod/new, /collections/create/new (dialog over table), and the new 404 for bad billing subpaths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the React Router v7 upgrade stack (3 of 5). Base:
greg/rr7-2-data-router.Two splat-route cleanups, landed before the future-flag PR because
v7_relativeSplatPathchanges how paths resolve inside splat routes.admin/billing: collapse the
billing/*splat into abillingparent with an index route + apaymentMethod/newchild. This:/admin/billing/billingroute, and/admin/billing/<garbage>previously rendered an empty content card because the splat swallowed it; it now correctly falls through to Page Not Found.lazyElement-wrapped (error boundary + suspense).collections: drop the
/*from the parent path; the existing*child already handles the splat. This matches react-router'sv7_relativeSplatPathguidance and is behavior-preserving.Verified in-app:
/admin/billing,/admin/billing/paymentMethod/new,/collections/create/new(dialog over table), and the new 404 for bad billing subpaths.