Skip to content

Operate without Tidal client ID & secret#3

Merged
estevaom merged 3 commits into
mainfrom
remove-tidal-requirement
Aug 2, 2025
Merged

Operate without Tidal client ID & secret#3
estevaom merged 3 commits into
mainfrom
remove-tidal-requirement

Conversation

@estevaom

@estevaom estevaom commented Aug 2, 2025

Copy link
Copy Markdown
Owner

Description

Allows Trackwatch to operate without Tidal client ID & secret

Fixes #2

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

2025-08-02-100452_hyprshot

Test Configuration:

  • OS: [e.g. Arch Linux x86_64 6.15.8-arch1-1]
  • Rust version: 1.88.0 (6b00bc388 2025-06-23)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@estevaom
estevaom requested a review from Copilot August 2, 2025 00:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables Trackwatch to function without requiring Tidal API credentials, making the Tidal integration optional while maintaining full functionality using playerctl metadata.

  • Modified configuration to treat Tidal credentials as optional rather than required
  • Updated the main application logic to gracefully handle missing Tidal provider
  • Enhanced documentation to clarify that Tidal integration is optional

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/config.rs Changed Tidal credentials from required to optional fields and added helper method
src/main.rs Updated to conditionally create Tidal provider and handle missing credentials gracefully
README.md Updated documentation to emphasize optional nature of Tidal integration
coverage_summary.py Removed coverage summary script (cleanup)

Comment thread src/main.rs Outdated
Comment thread src/main.rs Outdated
Comment thread src/main.rs Outdated
@codecov-commenter

codecov-commenter commented Aug 2, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main.rs 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

- Update version in Cargo.toml from 0.1.0 to 0.2.0                                                                                                                 - Add CHANGELOG.md documenting changes for v0.2.0                                                                                                                  - Notable changes: optional Tidal credentials
@estevaom
estevaom merged commit b8faa9a into main Aug 2, 2025
4 checks passed
@estevaom
estevaom deleted the remove-tidal-requirement branch August 2, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operate without Tidal client ID & secret

3 participants