Operate without Tidal client ID & secret#3
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables Trackwatch to function without requiring Tidal API credentials, making the Tidal integration optional while maintaining full functionality using playerctl metadata.
- Modified configuration to treat Tidal credentials as optional rather than required
- Updated the main application logic to gracefully handle missing Tidal provider
- Enhanced documentation to clarify that Tidal integration is optional
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/config.rs | Changed Tidal credentials from required to optional fields and added helper method |
| src/main.rs | Updated to conditionally create Tidal provider and handle missing credentials gracefully |
| README.md | Updated documentation to emphasize optional nature of Tidal integration |
| coverage_summary.py | Removed coverage summary script (cleanup) |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Update version in Cargo.toml from 0.1.0 to 0.2.0 - Add CHANGELOG.md documenting changes for v0.2.0 - Notable changes: optional Tidal credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows Trackwatch to operate without Tidal client ID & secret
Fixes #2
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: