warning check and test coverage#120
Merged
Merged
Conversation
dlefaudeux
requested changes
Mar 4, 2026
dlefaudeux
left a comment
Collaborator
There was a problem hiding this comment.
Would be nice if validate_simulation also says the name of the simulation for which there is an issue. Because it will be called before the run_simulations an otherwise it just says that is missing but not for which sim.
Collaborator
|
And for #93 I meant that it is supported to use as outputs in the output selection thing that are defined in the Observer building block |
dlefaudeux
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert check_simulation errors to warnings and add validate_simulation (#68, #93)
Issue #68: Replace hard errors with warnings in check_simulation to allow
incremental building of simulations. Users can now add simulations without
all building blocks (protocols, formulations) being present upfront.
A new validate_simulation() method provides strict pre-execution validation
that throws errors when required components are missing.
Issue #93: Add comprehensive tests for output selections and observer paths,
including default selections, set/add operations, and snapshot round-trip
preservation.
Changes:
new validate_simulation() method for strict validation before runs
for check_simulation tests; add 10+ test cases for validate_simulation;
add 5+ test cases for output selections/observers
This will resolve both #93 and #68