Crash fix shinyapp#117
Closed
PavelBal wants to merge 5 commits into
Closed
Conversation
The function was failing with invalid type/length (environment/1) when protocols/formulations list contained R6 objects. Now uses $ accessor and map_chr to properly handle R6 active bindings.
…ator - Wrap Protocol R6 object in list() when adding to SchemaItems (protocol.R) - Add [1] to handle duplicate protocol names in check_simulation (snapshot.R) - Give custom protocols unique names based on role (mod_protocol.R)
* Initial plan * Rename 'names' variable to 'extracted_names' to avoid conflict with base R function Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com>
…111) * Initial plan * Add comprehensive test coverage for get_names function Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com>
dlefaudeux
approved these changes
Feb 25, 2026
dlefaudeux
left a comment
dlefaudeux
left a comment
Collaborator
There was a problem hiding this comment.
It just adds some tests so all good for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.