Improve pk table#112
Merged
Merged
Conversation
…der when calculating the ration in ctsApp
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 90.56% 90.25% -0.31%
==========================================
Files 10 10
Lines 4248 4443 +195
==========================================
+ Hits 3847 4010 +163
- Misses 401 433 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlefaudeux
marked this pull request as ready for review
February 19, 2026 09:29
dlefaudeux
added a commit
that referenced
this pull request
Feb 24, 2026
* pretty print * add pretty print and comparison print * add function to automatically aggregate pop data * improve * sort by IndividualID before pivoting. To ensure Id are in the same order when calculating the ration in ctsApp * improve and add test and redocument * redoc * fix test * fix ci * fix ci * update test * style * improve coverage * add new functions to vignettes * Remove IndividualId column for pretty_pk and compare_pk
PavelBal
added a commit
that referenced
this pull request
Feb 24, 2026
* fix resolution * defaults outputs * updates tests on outpout schema * use osp.snapshots for individuals and populations * add victim only simulation in default template * update test default outputs * fix use osp.snapshot * Update test * improve doc of formualtions * update doc * add import from osp.snapshots fro individual creation * update test * review * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Improve pk table (#112) * pretty print * add pretty print and comparison print * add function to automatically aggregate pop data * improve * sort by IndividualID before pivoting. To ensure Id are in the same order when calculating the ration in ctsApp * improve and add test and redocument * redoc * fix test * fix ci * fix ci * update test * style * improve coverage * add new functions to vignettes * Remove IndividualId column for pretty_pk and compare_pk * update test after merge * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Pavel Balazki <pavel.balazki@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add nicer print of pk table
get_pk_analysis method will return the table with aggregated values for pop and specific number of signif digits
pretty_pk will print results in a list manner
compare_pk will print results in a per compound per path fashion with each simulations as a column for easy comparison across simulations
closes #62