Fix: In LCARS clock, do not delete the timer alarm when leaving clock. - #4325
Merged
Conversation
The TIMER_IDX alarm, used for the "1-tap timer" feature of the LCARS clock, should not be deleted by the UI remove() method. Otherwise, the timer is lost whenever another app takes control of UI, e.g., when a message is displayed by Messages app. This commit brings back the intended behavior: when leaving the clock, an active timer remains active; and when returning to the clock, the clock will take control of the timer (display its current state, etc) again.
Contributor
Author
|
FYI: The build/build failure is due to linter warnings that have nothing to do with the change I made. I.e., those warnings apply to the code already in BangleApps. I do not know what to do about that. |
added 2 commits
August 22, 2026 08:13
... as it's unused there.
Collaborator
|
I fixed the lint warnings and pushed to your branch and this PR. Should be unproblematic but could you please test it once and I'll merge then? :) |
Contributor
Author
From a quick test, yes, it appears to still be in good |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TIMER_IDX alarm, used for the "1-tap timer" feature of the LCARS clock, should not be deleted by the UI remove() method. Otherwise, the timer is lost whenever another app takes control of UI, e.g., when a message is displayed by Messages app.
This commit brings back the intended behavior: when leaving the clock, an active timer remains active; and when returning to the clock, the clock will take control of the timer (display its current state, etc) again.