chore: small fixes - #424
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes small maintenance tweaks across the pytest-embedded plugin and repo tooling, aiming to improve typing/option handling and keep CI/dev tooling up to date.
Changes:
- Add typing to
pytest_addoption, normalizegetoption()usage fortarget, and adjust session-finish exit status handling based on merged JUnit results. - Bump
ruff-pre-commithook version in.pre-commit-config.yaml. - Bump
dawidd6/action-download-artifactversion in the report workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pytest-embedded/pytest_embedded/plugin.py |
Minor typing/option-access tweaks and modified session exit status escalation logic. |
.pre-commit-config.yaml |
Updates Ruff pre-commit hook revision. |
.github/workflows/report.yml |
Updates the artifact download action version used by the reporting workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@lucasssvaz PTAL 4ed3b3e otherwise the test_pexpect_by_wokwi_esp32_arduino test case would fail |
.. no, test_arduino_serial_flash is failing now with this commit. could you show me how to fix it? |
|
@hfudev the test can use either the merged or the app only bin. Testing locally this patch fixes it. Can you confirm ? |
|
thank you @lucasssvaz |
No description provided.