Skip to content

fix(esp-wolfssl): send SNI and skip OCSP when skip_common_name is set #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrushikesh430 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(esp-wolfssl): send SNI and skip OCSP when skip_common_name is set #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef000a0
fix(esp-wolfssl): send SNI and skip OCSP when skip_common_name is set
hrushikesh430 Jun 15, 2026
35876bd
fix(esp-wolfssl): drop OCSP-skip, keep SNI on skip_common_name
hrushikesh430 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions port/esp_tls_wolfssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,17 @@ static esp_err_t set_client_config(const char *hostname, size_t hostlen, esp_tls
return ESP_ERR_WOLFSSL_SSL_SET_HOSTNAME_FAILED;
}
free(use_host);
} else {
/* skip_common_name only disables hostname *verification* of the peer
* certificate; SNI must still be sent so the server presents the
* certificate for the requested host (e.g. virtual hosts / CDNs).
* See esp-idf PR #14684. */
if (hostname != NULL && hostlen > 0) {
if ((ret = wolfSSL_UseSNI(tls->priv_ssl, WOLFSSL_SNI_HOST_NAME, hostname, hostlen)) != WOLFSSL_SUCCESS) {
ESP_LOGE(TAG, "wolfSSL_UseSNI failed, returned %d", ret);
return ESP_ERR_WOLFSSL_SSL_SET_HOSTNAME_FAILED;
}
}
}

if (cfg->alpn_protos) {
Expand Down