Repository navigation
feat(libsrtp): bump submodule for mbedTLS 4 support; allow IDF v6.0 - #1114
Conversation
|
@david-cermak PTAL |
232c60d to
788ad3f
Compare
- Bump libsrtp submodule v2.8.0 (24b3bf8) -> 2_x_dev d33b8ff, the merge of cisco/libsrtp#813 (mbedTLS 4 / PSA Crypto support). The adapters self-select on MBEDTLS_VERSION_MAJOR, so mbedTLS 3 (IDF v5.x) paths are unchanged. - Drop the idf '<6' cap from idf_component.yml; component version 2.8.0 -> 2.8.0~1. - CI: build get_started + test_apps on release-v6.0 too. host_test stays on v5.x: the IDF v6 linux target fails to link PSA apps (libtfpsacrypto.a needs mbedtls_ms_time / esp_mbedtls_mem_* from archives earlier on the link line) - an IDF-side ordering issue, independent of libsrtp. Verified locally: test_apps builds clean for esp32 on IDF v6.0.2 (mbedTLS 4.1.0); the v6 linux host_test link failure reproduces with IDF's own tf-psa-crypto references only.
788ad3f to
bf40da3
Compare
|
@david-cermak @euripedesrocha I have added a separate commit for version bump using the cz script. PTAL |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf40da3. Configure here.
| # Crypto support (cisco/libsrtp#813), so ESP-IDF v6 (mbedTLS 4) is | ||
| # supported alongside v5.x (mbedTLS 3) — the adapters self-select on | ||
| # MBEDTLS_VERSION_MAJOR. | ||
| idf: ">=5.4" |
There was a problem hiding this comment.
Submodule pin missing from commit
High Severity
This commit drops the IDF <6 cap, records SBOM hash d33b8ff, and re-enables IDF v6 builds, but the components/libsrtp/libsrtp gitlink is not updated in the same commit. Checkouts still resolve the old v2.8.0 tree without mbedTLS 4 adapters, so IDF v6 consumers fail to build while metadata claims support.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit bf40da3. Configure here.
There was a problem hiding this comment.
False alarm. The main commit which relaxes the IDF version check also contains the sha update and the tests are extended to IDF 6.0 as well in the same commit


Summary
v2.8.0release tag (24b3bf8) to2_x_devHEADd33b8ff— the merge of mbedTLS 4 / PSA Crypto support on 2_x_dev cisco/libsrtp#813, which adds mbedTLS 4 / PSA Crypto support to the 2.x mbedTLS adapters. The adapters self-select onMBEDTLS_VERSION_MAJOR, so mbedTLS 3 (IDF v5.x) code paths are untouched.idf <6cap fromidf_component.yml— this was gated on exactly this upstream work (the manifest comment referenced mbedTLS 4 support on 2_x_dev — plans? cisco/libsrtp#812). Component version2.8.0→2.8.0~1.get_started+test_appson release-v6.0 in addition to v5.4/v5.5.Verification
test_appsbuilds clean on IDF v6.0.2 (target esp32, mbedTLS 4.1.0) — full link, exit 0.Notes
libtfpsacrypto.areferencesmbedtls_ms_time/esp_mbedtls_mem_*that live in archives earlier on the link line (static archive ordering, IDF-side; reproduced with IDF's own libs, independent of libsrtp)..build-test-rules.ymldocuments this next to the disable rule.Note
Medium Risk
Touches SRTP crypto integration and moves off a release tag to a dev commit; scope is mostly CI/manifest with upstream adapters handling mbedTLS 3 vs 4.
Overview
Enables the libsrtp ESP-IDF component on ESP-IDF v6 by advancing the upstream submodule pin from v2.8.0 to
2_x_devd33b8ff(cisco/libsrtp#813), which adds mbedTLS 4 / PSA Crypto adapters that pick paths at compile time viaMBEDTLS_VERSION_MAJOR.The manifest
idf: ">=5.4,<6"upper bound is removed so v6 is allowed; component version is2.8.0~1with SBOM/metadata updated for the new pin. CI buildsget_startedandtest_appsonrelease-v6.0, and.build-test-rules.ymlno longer skips v6 for those apps.host_testremains disabled on IDF v6 with a clarified reason (IDF linux link ordering for PSA apps, not libsrtp).Reviewed by Cursor Bugbot for commit bf40da3. Bugbot is set up for automated code reviews on this repo. Configure here.