feat(esp-tls): Update esp_tls for improved wolfssl support (IDFGH-16561)#17682
feat(esp-tls): Update esp_tls for improved wolfssl support (IDFGH-16561)#17682gojimmypi wants to merge 1 commit into
Conversation
👋 Hello gojimmypi, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
gojimmypi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @gojimmypi , this PR is now migrated to esp-wolfssl repo (check this). Could you please take a look. Thanks. |
|
Hi @hrushikesh430 - yes, I see that there's now a submodule in the esp-wolfssl repo. That will likely pull in something like a half gig of mostly unrelated code, no? It is unfortunate that serious security continues to be considered an add-on, rather than a critical built-in, with wolfSSL integrated security removed from the EDP-IDF v6. (not even mentioned as a breaking change in the press release nor releases) Have you tested the esp-wolfssl with things like wolfSSH, wolfMQTT, wolfTPM, etc? Can I assume there's no longer interest in the Espressif wolfSSL Managed Components? I don't see how venturing off on customizations like that in espressif/esp-wolfssl#29 and the esp-wolfssl in general are helpful to serious industrial and commercial end users. I appreciate you asking my input. I just don't think that is the right direction to go. |
Description
This is the fifth in a series of pull requests to improve wolfSSL integration with the ESP-IDF as proposed in #16145
As there are multiple changes there, it was suggested that I break the update into smaller pieces.
This PR updates the requirements for wolfSSL in the
components/esp-tls/esp_tls.candcomponents/esp-tls/esp_tls.hRelated
See:
Testing
The fully-implemented update is on my wolfssl-dev branch. I've been testing with this esp_http_client_example.
See also the published wolfSSL Managed component that already includes the Certificate Bundle feature introduced in wolfSSL/wolfssl#7936
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Add safety checks and debug logging, validate tls before connecting, and make esp_tls_server_session_delete return int under wolfSSL via conditional prototypes/impl.
esp_tls_conn_readnow validatesdata;esp_tls_low_level_connvalidatestlsand returns-1on NULL.create_ssl_handlewith targethostname:port.esp_tls_server_session_deletereturnsintwhenCONFIG_ESP_TLS_USING_WOLFSSL,voidotherwise; updated declarations/definitions accordingly.ESP_TLS_HAS_WOLFSSLincomponents/esp-tls/esp_tls.hfor supported wolfSSL versions.Written by Cursor Bugbot for commit 31496c1. This will update automatically on new commits. Configure here.