Centralize all dependencies to the workspace#85
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes dependency declarations by moving crate versions (and some shared options) into the workspace-level Cargo.toml, then switching member crates to inherit them via workspace = true, aligning with the approach referenced in the linked mbedtls-rs PR.
Changes:
- Added a
[workspace.dependencies]section in the workspaceCargo.tomlto define shared dependency versions/options. - Updated
openthreadcrate dependencies to inherit from workspace dependencies. - Updated
openthread-sysdependencies and build-dependencies to inherit from workspace dependencies (includingmbedtls-rs-sys).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Cargo.toml | Introduces centralized workspace dependency definitions. |
| openthread/Cargo.toml | Switches crate dependencies to workspace = true inheritance. |
| openthread-sys/Cargo.toml | Switches (build-)dependencies to workspace = true inheritance, including mbedtls-rs-sys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@bjoernQ Also ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning identical to esp-rs/mbedtls-rs#162