Skip to content

xtask: check crates.io for reserved versions before publishing - #6209

Open
JurajSadel wants to merge 1 commit into
esp-rs:mainfrom
JurajSadel:yank
Open

xtask: check crates.io for reserved versions before publishing#6209
JurajSadel wants to merge 1 commit into
esp-rs:mainfrom
JurajSadel:yank

Conversation

@JurajSadel

Copy link
Copy Markdown
Contributor

Release tooling could select permanently reserved crates.io versions because it only checked Cargo.toml. plan and execute-plan now check crates.io first and publish-plan re-checks before uploading.

closes #5385

@bjoernQ

bjoernQ commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

I guess the check should only be done for plan? It's kind of unlikely we yank / release between the steps

At least checking right before cargo publish seems unnecessary - cargo publish would tell us the very same thing and even worse ... at that point we already released a few crates with the potentially wrong dependency version?

@bjoernQ

bjoernQ commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Or maybe the check should be in / before execute-plan? Not sure if we really want that "auto-choose a free version" - maybe just fail and let the human decide how to change the release plan?

But I'm not too familiar with the release process - maybe I'm missing something here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add prerelease check to ensure we're not choosing a previously released version

2 participants