Enable I2S for ESP32-S31 - #6197
Open
bjoernQ wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
/hil full --test i2s |
|
Triggered full HIL run for #6197. Run: https://github.com/esp-rs/esp-hal/actions/runs/32838186140 Status update: ❌ HIL (full) run failed (conclusion: failure). |
Contributor
Author
|
/hil full --test i2s |
|
Triggered full HIL run for #6197. Run: https://github.com/esp-rs/esp-hal/actions/runs/32841030208 Status update: ❌ HIL (full) run failed (conclusion: failure). |
bjoernQ
marked this pull request as ready for review
August 25, 2026 11:43
bjoernQ
requested review from
MabezDev,
bugadani and
playfulFence
as code owners
August 25, 2026 11:43
bugadani
reviewed
Aug 25, 2026
| pub mod master; | ||
|
|
||
| #[cfg(i2s_clock_configured_by_hp_sys_clkrst)] | ||
| #[cfg(all(i2s_clock_configured_by_hp_sys_clkrst, esp32p4))] |
Contributor
There was a problem hiding this comment.
This doesn't make much sense, does it?
#[cfg(i2s_clock_configured_by_hp_sys_clkrst)]
#[cfg_attr(esp32p4, path = "hp_sys_clkrst_p4.rs")]
#[cfg_attr(esp32s31, path = "hp_sys_clkrst_s31.rs")]
mod hp_sys_clkrst;
Contributor
Author
There was a problem hiding this comment.
sure - the chip is more than enough on it's own
bugadani
reviewed
Aug 25, 2026
| support_status = "not_supported" | ||
| support_status = "partial" | ||
| version = 3 | ||
| # 0 = XTAL. Prefer APLL (1) once the clock tree can configure it. |
Contributor
There was a problem hiding this comment.
once the clock tree can configure it
Maybe first the clock config should be part of the clock tree :P
bugadani
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
esp-hal