Enable PCNT on ESP32-S31, rework API - #6191
Draft
bugadani wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
/hil full |
|
Triggered full HIL run for #6191. Run: https://github.com/esp-rs/esp-hal/actions/runs/32751192791 Status update: HIL (full) run is still in progress or status unknown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCNT now follows the one channel - one singleton pattern. There is no common setup, just a bit of mutexing because of some shared register.
Changelog
esp-hal
PCNTn_UNITmsingletons instead of aPcntdriver.Migration guide
esp-hal/PCNT driver
Construct units from singletons
Pcnt::newand theunit0…unitNfields are gone. Build aUnitfrom aPCNTn_UNITmsingleton (PCNTis block 0).Unitno longer has a unit-index type parameter.On ESP32-S31,
PCNT1_UNIT0...PCNT1_UNIT3is also available.Register interrupt handlers on the unit (
unit0.set_interrupt_handler(...)). The hardware still has one IRQ per register block; the driver dispatches to the unit whose status bit is set.