Skip to content

nul-terminate cookie read from control connection in iperf_accept #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dxbjavid wants to merge 1 commit into from
+6 −0
Closed

nul-terminate cookie read from control connection in iperf_accept #2054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/iperf_server_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,12 @@ iperf_accept(struct iperf_test *test)
i_errno = IERECVCOOKIE;
goto error_handling;
}
/*
* The cookie is later handled as a NUL-terminated string (printed
* and copied into JSON output), but a peer can send COOKIE_SIZE
* non-NUL bytes, so make sure it is terminated before it is used.
*/
test->cookie[COOKIE_SIZE - 1] = '\0';
FD_SET(test->ctrl_sck, &test->read_set);
if (test->ctrl_sck > test->max_fd) test->max_fd = test->ctrl_sck;

Expand Down
Loading