Do not allow setting zero parallel streams - #2048
Merged
bmah888 merged 2 commits intoJun 26, 2026
Merged
Conversation
Contributor
|
Thanks for the PR! This used to be a part of PR #2045, right? |
Contributor
Author
bmah888
approved these changes
Jun 26, 2026
bmah888
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this code change looks good.
In the future, I'd like to request not putting whitespace cleanups in the same PR as bugfixes or other functional changes. Or at least not put them in the same commits. This makes it harder to tell exactly what the significant changes were in each commit. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master 3.21+
Issues fixed (if any): none
Brief description of code changes (suitable for use as a commit message):
Dot not allow
--parallelto be zero (noticed this issue as the latest verification change caused a conflict in an old PR I submitted). Changed the error message accordingly.(Also includes a cosmetic changes: indentation fix and changing
}elseto} else.)