Skip to content

Do not allow setting zero parallel streams - #2048

Merged
bmah888 merged 2 commits into
esnet:masterfrom
davidBar-On:not-allow-zero-parallel-streams
Jun 26, 2026
Merged

Do not allow setting zero parallel streams#2048
bmah888 merged 2 commits into
esnet:masterfrom
davidBar-On:not-allow-zero-parallel-streams

Conversation

@davidBar-On

@davidBar-On davidBar-On commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master 3.21+

  • Issues fixed (if any): none

  • Brief description of code changes (suitable for use as a commit message):

Dot not allow --parallel to be zero (noticed this issue as the latest verification change caused a conflict in an old PR I submitted). Changed the error message accordingly.

(Also includes a cosmetic changes: indentation fix and changing }else to } else.)

@bmah888 bmah888 changed the title Do not allow settting zero parralel streams Do not allow setting zero parallel streams Jun 15, 2026
@bmah888

bmah888 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! This used to be a part of PR #2045, right?

@davidBar-On

Copy link
Copy Markdown
Contributor Author

This used to be a part of PR #2045, right?

Yes. I separated the PRs as it seems that merging of PR #2045 is not straightforward as I thought it is, at least not its testing.

@bmah888 bmah888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this code change looks good.

In the future, I'd like to request not putting whitespace cleanups in the same PR as bugfixes or other functional changes. Or at least not put them in the same commits. This makes it harder to tell exactly what the significant changes were in each commit. Thanks!

@bmah888
bmah888 merged commit 71933f4 into esnet:master Jun 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants