feat(esm_catalog): PR-A1g — contacts STAC extension#1506
Open
mandresm wants to merge 9 commits into
Open
Conversation
- Contact dataclass in context.py: name, orcid, institution, roles, from_config() classmethod, validate() for production checks - contacts field added to CollectionContext (list[Contact]) - Production validation: at least one contact required, each contact must have name + institution when production=True - contacts.py: add_contacts(item, ctx) maps ctx.contacts to STAC contacts format (identifier/scheme for ORCID, organization for institution) - 12 new tests; 29 total passing Co-Authored-By: PavanSiligam <pavan.siligam@gmail.com> Co-Authored-By: Paul Gierz <pgierz@awi.de> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…need to be included in the stac item by the make_item anyway Co-Authored-By: Claude <noreply@anthropic.com>
mandresm
marked this pull request as ready for review
July 6, 2026 14:54
siligam
reviewed
Jul 6, 2026
siligam
left a comment
siligam
left a comment
Contributor
There was a problem hiding this comment.
Nice and compact, tests included. One real conformance bug (the identifier shape) plus a few small robustness/cleanup things — details inline.
2 tasks
siligam
added a commit
that referenced
this pull request
Jul 22, 2026
A bare `epoch:`/`period:` under general.paleo is present-but-None, and `if "epoch" in paleo_config` let it through, writing a schema-invalid `"paleo:epoch": null` into the item. Nothing calls pystac .validate() in the pipeline, so it shipped unchecked. Gate on truthiness instead. Same silent-null-write class as the contacts `roles` case on #1506.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds feature
PR-A1g — Contacts extensiondescribed in https://github.com/esm-tools/esm_tools/blob/22519379dc96e17e65d8d302c6d969375f0ec139/src/esm_catalog/PR-A1A-STAC-FOUNDATION-PLAN.md.Adds contact info to the STAC item, and checks whether mandatory info is provided if the experiment is labelled as production.
TODOs