Skip to content

Support Erlang/OTP 29 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdbrnowski merged 1 commit into from
Jun 23, 2026
Merged

Support Erlang/OTP 29 #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Test OTP ${{matrix.otp_vsn}}
strategy:
matrix:
otp_vsn: ['28', '27', '26']
otp_vsn: ['29', '28', '27']
rebar_vsn: ['3.27']
runs-on: 'ubuntu-24.04'
env:
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
name: Benchmark suite execution OTP ${{matrix.otp_vsn}}
strategy:
matrix:
otp_vsn: ['28', '27']
otp_vsn: ['29', '28']
elixir_vsn: ['1.19']
rebar_vsn: ['3.27']
runs-on: 'ubuntu-24.04'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v6
- uses: erlef/setup-beam@v1
with:
otp-version: "28"
otp-version: "29"
rebar3-version: "3.27"
- run: rebar3 compile
- run: rebar3 hex publish -r hexpm --yes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/revert-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v6
- uses: erlef/setup-beam@v1
with:
otp-version: "28"
otp-version: "29"
rebar3-version: "3.27"
- run: rebar3 hex publish --revert ${{ inputs.version }} -r hexpm --yes
env:
Expand Down
5 changes: 3 additions & 2 deletions src/exml.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ to_iolist(Elements, Pretty) when is_list(Elements) ->

-spec to_binary_nif(element(), prettify()) -> binary().
to_binary_nif(#xmlel{} = Element, Pretty) ->
case catch exml_nif:to_binary(Element, Pretty) of
{'EXIT', Reason} -> erlang:error({badxml, Element, Reason});
try exml_nif:to_binary(Element, Pretty) of
Result when is_binary(Result) -> Result
catch
_Class:Reason -> erlang:error({badxml, Element, Reason})
end.
Loading