fix: clarify -refresh instructions and default the curl file path#15
Merged
Conversation
The old prompt said "go to your orders page" and "find any getOrder request", which doesn't work: getOrder only fires from an individual order's detail view, not the orders list, and it's easy to miss in an unfiltered Network tab. Spell out clicking into an order and searching the Network tab for "getOrder". Also default the curl file path to ./curl.txt (already gitignored) so the common case is just pressing Enter instead of typing a path.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 56.00% 55.04% -0.97%
==========================================
Files 9 9
Lines 857 872 +15
==========================================
Hits 480 480
- Misses 335 350 +15
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-refreshprompt said "go to your orders page" and "find any getOrder request", butgetOrderonly fires from an individual order's detail view, not the list page, and it's easy to miss in an unfiltered Network tab.getOrder)../curl.txt(already gitignored) so pressing Enter uses it instead of requiring the user to type a path every time.Test plan
make fmt && make lint && go test -v -race ./...all pass locallygo build -o walmart-cli ./cmd/walmartbuilds clean./walmart-cli -refresh, confirmed new prompt renders correctly and default path resolves to an absolute pathitemize walmart -dry-runsuccessfully (previously failing with HTTP 456)