Repository navigation
Update tiff_segfault.t skip Strawberry Perl 5.34 - #20
Closed
PhilterPaper wants to merge 1 commit into
Closed
PhilterPaper wants to merge 1 commit into
PhilterPaper wants to merge 1 commit into
Conversation
Strawberry Perl 5.34 has bug that blows up this test, preventing install. Bypass Windows + Perl 5.34 test.
Contributor
|
See #21 for a potential fix that leaves the test in place on windows |
Author
|
PR 21 appears to fix the root cause of the install failure, so it's fine by me to close this when you're happy with the new fix. I did note (in #21) that t/pod_cov.t fails on all levels on my system, but I can't see why PR 21 would cause that. Also for Strawberry Perl 5.28, t/string.t has a couple of failed tests for XML::SAX, though again, PR 21 shouldn't have done anything to cause that. |
Owner
|
Closing this ---I just merged #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strawberry Perl 5.34 has bug that blows up this test, preventing install. Bypass Windows + Perl 5.34 test. This will skip other Perls too, but I don't have a test specifically for Strawberry Perl. Maybe one could snoop around the directory structure to look for Strawberry-specific directories or files?
Ref RT 172758