Skip to content

Add Custom hitCallback Functionality #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timdmackey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Custom hitCallback Functionality #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions blueprints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ form:
trackingId:
type: text
size: medium
label: PLUGIN_GANALYTICS.TACKING_ID
help: PLUGIN_GANALYTICS.TACKING_ID_HELP
label: PLUGIN_GANALYTICS.TRACKING_ID
help: PLUGIN_GANALYTICS.TRACKING_ID_HELP
placeholder: "UA-00000000-0"
validate:
required: true
Expand Down Expand Up @@ -73,6 +73,13 @@ form:
size: small
default: "ga"

hitCallback:
type: textarea
label: PLUGIN_GANALYTICS.HITCALLBACK
help: PLUGIN_GANALYTICS.HITCALLBACK_HELP
size: large
placeholder: "function() { form.submit(); }"

async:
type: toggle
label: PLUGIN_GANALYTICS.ASYNC
Expand Down
10 changes: 8 additions & 2 deletions ganalytics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,15 @@ private function getTrackingSettings($trackingId, $objectName)
'trace-debug' => "window.ga_debug = {trace: true};",
'create' => "{$objectName}('create', '{$trackingId}', {$cookie_config});",
'anonymize' => "{$objectName}('set', 'anonymizeIp', true);",
'force-ssl' => "{$objectName}('set', 'forceSSL', true);",
'send' => "{$objectName}('send', 'pageview');"
'force-ssl' => "{$objectName}('set', 'forceSSL', true);"
];
// If hitCallback has been specified, include it on pageview send
$hitCallback = $this->config->get('plugins.ganalytics.hitCallback');
if ($hitCallback) {
$settings['send'] = "{$objectName}('send', 'pageview', { hitCallback: $hitCallback });";
} else {
$settings['send'] = "{$objectName}('send', 'pageview');";
}

if (!$this->config->get('plugins.ganalytics.debugTrace', false)) unset ($settings['trace-debug']);
if (!$this->config->get('plugins.ganalytics.anonymizeIp', false)) unset ($settings['anonymize']);
Expand Down
6 changes: 4 additions & 2 deletions languages/de.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ PLUGIN_GANALYTICS:
SECTION_ADVANCED: "Erweitert"
SECTION_COOKIE: "Cookie"
SECTION_DEBUG: "Debugging"
TACKING_ID: "Tracking-ID"
TACKING_ID_HELP: "Google Analytics Tracking-ID"
TRACKING_ID: "Tracking-ID"
TRACKING_ID_HELP: "Google Analytics Tracking-ID"
HITCALLBACK: "(NEEDS TRANSLATION) hitCallback Function"
HITCALLBACK_HELP: "(NEEDS TRANSLATION) Provide your callback function to be triggered when page hit is tracked."
POSITION: "Code-Position"
POSITION_HELP: "Position des Codes im HTML-Dokument (Head oder Body)"
POSITION_HEAD: "Kopf"
Expand Down
6 changes: 4 additions & 2 deletions languages/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ PLUGIN_GANALYTICS:
SECTION_ADVANCED: "Advanced"
SECTION_COOKIE: "Cookie"
SECTION_DEBUG: "Debug"
TACKING_ID: "Tracking ID"
TACKING_ID_HELP: "Google Analytics Tracking ID"
TRACKING_ID: "Tracking ID"
TRACKING_ID_HELP: "Google Analytics Tracking ID"
HITCALLBACK: "hitCallback Function"
HITCALLBACK_HELP: "Provide your callback function to be triggered when page hit is tracked."
POSITION: "Code Position"
POSITION_HELP: "Code Position in the HTML document (head or body)"
POSITION_HEAD: "Head"
Expand Down
6 changes: 4 additions & 2 deletions languages/es.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ PLUGIN_GANALYTICS:
SECTION_ADVANCED: "Avanzada"
SECTION_COOKIE: "Cookie"
SECTION_DEBUG: "Depuración"
TACKING_ID: "ID Seguimiento"
TACKING_ID_HELP: "ID Seguimiento estadísticas Google"
TRACKING_ID: "ID Seguimiento"
TRACKING_ID_HELP: "ID Seguimiento estadísticas Google"
HITCALLBACK: "(NEEDS TRANSLATION) hitCallback Function"
HITCALLBACK_HELP: "(NEEDS TRANSLATION) Provide your callback function to be triggered when page hit is tracked."
POSITION: "Posición del Código"
POSITION_HELP: "Posición del código en el documento HTML (cabecera o cuerpo)"
POSITION_HEAD: "Cabecera"
Expand Down