refactor(core): extract DeepMap's three cohesive subsystems - #278
Merged
Conversation
eschizoid
force-pushed
the
design/engine-explain
branch
from
July 30, 2026 23:04
6a3ac14 to
a299fd9
Compare
eschizoid
force-pushed
the
design/deepmap-seams
branch
from
July 30, 2026 23:05
9eadfdc to
342d33b
Compare
DeepMap drops from ~2100 to ~1450 lines by moving three deletion-test- passing seams into package-private siblings, bodies verbatim: - TelescopeFixups — the telescope-row overlay subsystem: the two exhaustive per-row forward/backward switches, Conditional peeling, ZIP cardinality, and overrideTargetField, behind one static wrap(...) entry point. - ContainerLifts — the container copy/lift Isos (collection/map copy, the three lift*IntoTargetRaw shapes) and the java.base allocator tables. - Placeholders — placeholderIsoFor, defaultAllocatorIso, recursiveDefault, primitiveDefault, beanIntermediateAllocatable, and NULLING_ISO. What remains in DeepMap is the actual engine: populateIso / autoIso / assembleIso plus the pairing passes. Behavior identical — full :core and :internal suites green.
eschizoid
force-pushed
the
design/deepmap-seams
branch
from
July 30, 2026 23:08
342d33b to
7561ca9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=========================================
Coverage 79.78% 79.79%
Complexity 2046 2046
=========================================
Files 88 91 +3
Lines 6491 6492 +1
Branches 1330 1330
=========================================
+ Hits 5179 5180 +1
Misses 770 770
Partials 542 542 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (stacked on the engine-explain PR)
Item 5 of the design round: DeepMap's three extraction seams, exactly as the architecture inspection specified — each passed the deletion test (interface strictly smaller than the body's knowledge). DeepMap drops from ~2,100 to ~1,450 lines; what remains is the actual engine (
populateIso/autoIso/assembleIso+ the pairing passes). Bodies moved verbatim:TelescopeFixupswrap(...)ContainerLiftsPlaceholdersplaceholderIsoFor/ default-tree machinery /NULLING_ISOBehavior identical — full
:core+:internalsuites green.