feat(core): every engine explains itself — fromMap, merge, multi-edit trails - #277
Merged
Conversation
…edit trails The deep mapper promised "the report cannot drift from what the mapper does" while two of three engines and every multi-edit normalizer explained as empty — despite each building exactly the per-slot data a trail wants and then discarding it. - FromMap emits one Transformed row per extract (map key → component, through the row's converter) and one MISSING_SOURCE skip per defaulted slot, derived from the same slot alignment the forward path runs on. - Merge emits one Mapped row per bound component (SourceClass.field → target field — ResolvedStep now records the source-side property name) and one MISSING_SOURCE skip per unbound component, derived from the same positional plan the forward path binds. - Telescope.all products carry the concatenation of their edits' trails in edit order, on both the fused and the sequential branches. EngineExplainTest pins all three (each previously reported empty).
eschizoid
force-pushed
the
design/engine-explain
branch
from
July 30, 2026 23:04
6a3ac14 to
a299fd9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
============================================
+ Coverage 79.74% 79.78% +0.04%
- Complexity 2041 2046 +5
============================================
Files 88 88
Lines 6471 6491 +20
Branches 1324 1330 +6
============================================
+ Hits 5160 5179 +19
- Misses 769 770 +1
Partials 542 542 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (stacked on #276)
Item 4 of the design round: every engine explains itself. The deep mapper promised "the report cannot drift from what the mapper does" while fromMap, merge, and every
Telescope.allnormalizer explained as empty — despite each building exactly the per-slot data a trail wants, then discarding it.Transformedrow per extract (map key → component through the row's converter), oneMISSING_SOURCEskip per defaulted slot — derived from the same slot alignment the forward path runs on.Mappedrow per bound component (SourceClass.field → target;ResolvedStepnow records the source-side property name), one skip per unbound component — derived from the same positional plan the forward path binds.Telescope.all: the product's trail is the concatenation of its edits' trails in edit order, on both the fused and sequential branches.EngineExplainTestpins all three (each previously reported empty). Because every trail is derived from the data the forward path executes, the drift-free property now genuinely holds for all three engines.