fix: consumer module-info metrics requires + test homing - #290
Merged
Conversation
- kpipe-consumer imports io.github.eschizoid.kpipe.metrics.* in four files but its module-info never required the metrics module - it compiled only through producer's 'requires transitive'. Declared directly (transitive: withMetrics(ConsumerMetrics) is public API), so tightening producer's edge later cannot break consumer. - Deleted the consumer-module ConsumerMetricsReporterTest: it shared an exact FQCN with the kpipe-metrics test for the same public class (breaking coverage attribution) and its three Mockito scenarios are subsumed by the metrics module's eight plain ones. - Moved CompositeMessageSinkJCStressTest producer->core jcstress: the SUT is a core class in the core-owned io.github.eschizoid.kpipe.sink package; core's concurrency gate no longer depends on producer's jcstress task.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
============================================
- Coverage 79.26% 79.21% -0.06%
+ Complexity 1032 1030 -2
============================================
Files 83 83
Lines 3560 3560
Branches 457 457
============================================
- Hits 2822 2820 -2
Misses 546 546
- Partials 192 194 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture-pass P0 items #3 and #4 (audit 2026-07-25):
ConsumerMetricsin 4 files with no directrequires— compiled only via producer's transitive re-export. Now declared (requires transitive, sincewithMetricsis public API).io.github.eschizoid.kpipe.metrics.ConsumerMetricsReporterTestclasses across modules; consumer's copy re-tested another module's public class from the wrong module — deleted (scenarios subsumed by the metrics-module original).CompositeMessageSinkJCStressTesttargets a core class but lived in producer's jcstress source set — moved to core (already wired: CI runs:lib:kpipe-core:jcstress).