added checkbox to accept code of conduct to subcribe page#506
Open
BendeCort wants to merge 11 commits into
Open
added checkbox to accept code of conduct to subcribe page#506BendeCort wants to merge 11 commits into
BendeCort wants to merge 11 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
=========================================
Coverage 29.71% 29.71%
Complexity 547 547
=========================================
Files 81 81
Lines 2100 2100
=========================================
Hits 624 624
Misses 1476 1476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThijsEgberts
requested changes
Apr 2, 2026
ThijsEgberts
left a comment
ThijsEgberts
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good, but I have some small cosmetic changes and some more important ones:
- Please make sure to actually make the code of conduct a required field in the
PendingUserController(line 92) - Add a string in
resources/lang/en/validation.phpto render a code of conduct error more nicely (capitalization)
marijnvanderhorst
requested changes
Apr 5, 2026
Co-authored-by: ThijsEgberts <104772243+ThijsEgberts@users.noreply.github.com>
Co-authored-by: ThijsEgberts <104772243+ThijsEgberts@users.noreply.github.com>
Co-authored-by: Marijn van der Horst <github@marijnvanderhorst.nl>
…c-ic/esac.nl into add-code-of-conduct-checkbox
marijnvanderhorst
had a problem deploying
to
Build
GitHub Actions
Failure
Co-authored-by: Marijn van der Horst <github@marijnvanderhorst.nl>
Co-authored-by: Marijn van der Horst <github@marijnvanderhorst.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added checkbox to accept code of conduct to subcribe page
and the code of conduct in a similar dropdown menu as the terms and conditions etc